christopherdro/react-native-calendar

Inconsistency in passing value to callbacks

Open

#54 opened on Jul 19, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (234 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (535 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I spotted inconsistency in callback values. Namely these: onSwipePrep and onSwipeNext receive moment instance. onDateSelected receives date in plain string format.

Unifying this issue is essentially a breaking change, but it would be nice to be consistent.

Contributor guide

Research direction
Locate the invocations of each callback (onSwipePrep, onSwipeNext, onDateSelected) in the source code, trace the value passed, and propose a unified format (e.g., always moment instance or always string).
Tech stack
javascriptreact native
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React NativeJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60