chatmail/relay

cmdeploy running unbound-anchor is redundant

Closed

#542 opened on Apr 2, 2025

View on GitHubContributor guide
 (2 comments) (1 reaction) (0 assignees)Python (65 forks)auto 404
good first issue

Repository metrics

Stars
 (476 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/chatmail/relay/blob/5ba99dc78214808d0e95b86e7e4c37b974b7eef3/cmdeploy/src/cmdeploy/__init__.py#L595-L601

This is redundant as the unbound service automatically calls this:

[Unit]
Description=Unbound DNS server
Documentation=man:unbound(8)
After=network.target
Before=nss-lookup.target
Wants=nss-lookup.target

[Service]
Type=notify
Restart=on-failure
EnvironmentFile=-/etc/default/unbound
ExecStartPre=-/usr/libexec/unbound-helper chroot_setup
ExecStartPre=-/usr/libexec/unbound-helper root_trust_anchor_update
ExecStart=/usr/sbin/unbound -d -p $DAEMON_OPTS
ExecStopPost=-/usr/libexec/unbound-helper chroot_teardown
ExecReload=+/bin/kill -HUP $MAINPID

[Install]
WantedBy=multi-user.target

It's handled by ExecStartPre in the systemd unit file

Contributor guide

Research direction
Inspect the code at lines 595-601 in cmdeploy/ init .py and remove the redundant unbound anchor call. Also verify if the ExecStartPre in the unbound systemd unit file already handles it.
Tech stack
python
Domain
backenddevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80