chakra-core/ChakraCore

Redeclaration of a function* inside a block definition

Open

#6,459 opened on Jun 8, 2020

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,226 forks)batch import
Bughelp wanted

Repository metrics

Stars
 (9,256 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi everyone, I found a case of redeclaration of a generator function inside a block definition.

version: 1.11.19 OS: Linux Ubuntu 19.10 x64

steps to reproduce:

{ function* f() { yield 1 } function f() { print(2) } } f() Actual results: 2

Expected results: SyntaxError: Identifier 'f' has already been declared

V8, SpiderMonkey works as expected.

cinfuzz

Contributor guide

Research direction
Inspect the parser's handling of function declarations inside block statements, specifically for generator functions.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75