chakra-core/ChakraCore

don't emit LdNativeCodeData if function doesn't use any

Open

#5,516 opened on Jul 24, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,226 forks)batch import
Performancehelp wanted

Repository metrics

Stars
 (9,256 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Most JS functions will have a bailout or something that uses native code data, but wasm functions never will (or almost never). We should change to only emit this instruction only if we actually need it. It's a bit tricky to track, since most of the uses are introduced during lowerer or later, but it should be doable.

Contributor guide

Research direction
Inspect the lowerer pass and identify where LdNativeCodeData instructions are added. Determine if the function uses native code data before emitting.
Tech stack
javascript
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30