chakra-core/ChakraCore

JSRT: JsDeleteIndexedProperty does not tell successful or not

Open

#504 opened on Mar 10, 2016

View on GitHubContributor guide
 (10 comments) (0 reactions) (0 assignees)JavaScript (1,226 forks)batch import
APIsBugSeverity: 3good first issuehelp wanted

Repository metrics

Stars
 (9,256 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

JsDeleteIndexedProperty API does not tell if the deletion is successful or not, unlike JsDeleteProperty which returns that info in "result". The former also misses "useStrictRules" flag which exists in the later.

JsDeleteIndexedProperty(JsValueRef object, JsValueRef index)

JsDeleteProperty(JsValueRef object, JsPropertyIdRef propertyId,
                 bool useStrictRules,
                 JsValueRef *result)

These 2 APIs should be comparable and consistent.

Contributor guide

Research direction
Compare the implementation of JsDeleteIndexedProperty and JsDeleteProperty in the ChakraCore source code. Modify JsDeleteIndexedProperty to return a JsErrorCode indicating success/failure and add a useStrictRules parameter. Ensure the change is consistent with existing API patterns and update any internal callers.
Tech stack
ccpp
Domain
apibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60