casesandberg/react-color

Propogate view from toggle button on ChromePicker

Open

#584 opened on Feb 5, 2019

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (921 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (12,320 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The current view state of the ChromeFields input in ChromePicker is not externally accessible and makes it difficult to tie in with other components.

I suggest adding an onToggleView callback to pass the new "view" state as a parameter back up to its container. e.g: if(this.props.onToggleView){ this.props.onToggleView('hex'); }

Contributor guide

Research direction
Review the ChromePicker component and implement the onToggleView callback prop to propagate the current view state.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90