canonical/cos-lib

allow using cosl.coordinated_workers.S3ConnectionInfo outside of tempo-loki-mimir

Open

#119 opened on Jan 27, 2025

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Python (6 forks)auto 404
Status: TriageType: Buggood first issue

Repository metrics

Stars
 (0 stars)
PR merge metrics
 (PR metrics pending)

Description

Bug Description

Right now attempting to import that module from outside the HA charms (e.g. Parca) will result in import errors because of the check-charm-libs-installed thing we do on import.

we should either refactor cosl to run that check on-demand rather than on import, or lift anything that needs not be under that check outside of the coordinated_workers module so other charms can use them without ugly workarounds.

To Reproduce

n/a

Environment

n/a

Relevant log output

n/a

Additional context

No response

Contributor guide

Research direction
Locate the import time check in cosl.coordinated workers that causes the import error. Refactor it to run on demand, or move S3ConnectionInfo and related utilities to a separate module outside coordinated workers to allow imports without the check.
Tech stack
python
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70