bvaughn/react-highlight-words

Adjacent active chunks are handled as a single chunk

Open

#68 opened on Dec 4, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (176 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (2,303 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

See this example: https://codesandbox.io/s/7j2njo9l2q.

searchWords={["e"]}
textToHighlight="sleep"
activeIndex={0}

highlights both ee instead of just the first e. With activeIndex={1} nothing gets highlighted.

Contributor guide

Research direction
Examine the highlight method in the component, specifically how it handles overlapping or adjacent matching chunks. The issue is that when the same word appears consecutively, they are merged into one chunk instead of being treated separately. Look at the algorithm that splits text into chunks and ensure that each match is its own chunk, respecting the activeIndex prop. Consider using a regex that captures all matches without merging adjacent ones.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65