bpmn-io/dmn-moddle

DMNStyle is unrecognized

Open

#26 opened on Apr 5, 2022

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (3 forks)auto 404
backlogbuggood first issuemiwgspring cleaning

Repository metrics

Stars
 (14 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the Bug

When I import a diagram with DMNStyle, I get a warning:

[diagram_1.dmn] unparsable content <dmndi:DMNStyle> detected
	line: 15
	column: 8
	nested error: unrecognized element <dmndi:DMNStyle> [ warning ]

Diagram: dmn.txt

The bug is probably derived from the dmndi.xmi which specifies styles as isDerived=true which causes our parser to mark them as isVirtual=true in our toolkit. I don't see a reason why the XMI specifies styles as a derived attribute.

Steps to Reproduce

Open attached diagram in Camunda Modeler.

Expected Behavior

Style is accepted.

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]

Contributor guide

Research direction
Examine the moddle descriptor for dmndi:DMNStyle and the parsing logic that handles derived attributes from the XMI schema. Reproduce the error with a unit test using the attached diagram, then trace where DMNStyle is incorrectly marked as virtual.
Tech stack
javascriptnodejs
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65