blakeblackshear/frigate-hass-integration

Device URLs not helpful when using the addon

Open

#257 opened on May 15, 2022

View on GitHub
 (11 comments) (2 reactions) (0 assignees)Python (189 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (1,237 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Version of the custom_component

v2.3

Configuration

image

Describe the bug

The newly added Device URLs aren't helpful when the Frigate server is an addon. See:

https://user-images.githubusercontent.com/29582865/168490289-b5e35400-cbdc-4a0d-ae33-23d0110f5c3d.mp4

IMO: Taking the HA internal URL + the right port is better than using the configured Frigate URL (which will never be accessible from a browser).

Ideally, the HA ingress should allow custom paths instead of only the /dashboard home. That would be better to redirect to, as it would work both internally and externally.

Debug log

N/A

Contributor guide

Research direction
Examine the code that generates Device URLs in the Frigate integration. Modify to use Home Assistant internal URL with proper port or leverage HA ingress for addon environments. Ensure URLs are accessible from browser.
Tech stack
python
Domain
backendfrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitHome Assistant
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65