beeware/toga

Readonly Textinput beeps on focus loss with keyboard on GTK

Open

#2,554 opened on May 6, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (624 forks)batch import
buggood first issuegtklinux

Repository metrics

Stars
 (3,615 stars)
PR merge metrics
 (Avg merge 1d 10h) (47 merged PRs in 30d)

Description

Describe the bug

Under GTK, If a readonly text input loses focus as a result of keyboard input (i.e., pressing tab), a beep is emitted.

Steps to reproduce

  1. Run Tutorial 1
  2. Type Tab twice

A beep will be emitted when the Celsius field loses focus.

Expected behavior

No beep should be emitted.

Screenshots

No response

Environment

  • Operating System: Ubuntu 22.04
  • Python version: All
  • Software versions:
    • Toga: 0.4.2+

Logs

Additional context

No beep is emitted on loss of focus.

It's arguable whether the readonly widget should be able to accept focus at all - that's the behavior on macOS. If this is acceptable, calling native.set_can_focus() as part of set_readonly() might be a fix for this.

There is likely similar issues on any other widget with a clear input focus and a readonly option.

Contributor guide

Research direction
Investigate the GTK backend widget implementation, specifically the `set readonly()` method. Look at how other read only widgets handle focus. Consider calling `native.set can focus(False)` in `set readonly()` to prevent focus entirely, as suggested in the issue. Also examine if other widgets with readonly option have similar issues. Check the relevant source file in `src/gtk/toga gtk/widgets/` for the text input implementation.
Tech stack
python
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
basic Pythonfamiliarity with Togaunderstanding of GTK focus handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60