bafnetwork/baf-wallet-v2

Add helpful text to bot's `sendMoney` response

Open

#71 opened on May 7, 2021

View on GitHub
 (0 comments) (0 reactions) (1 assignee)TypeScript (0 forks)auto 404
good first issuesecurityux

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

How to use sendMoney isn't really all that clear. At minimum, should probably:

  • Have the bot say "check ur dm" or something like that so the user knows to check their DM for the link
  • Add some instructional text to the user's DM that makes it clear the user needs to click the link to send the tx

However, we might also want to somehow have the bot react to the message containing the link or delete it or send another message or some other way of letting the user know not to click old links in the user's DM with the bot and replay attack themselves. This may very well belong in a different issue, as a generic replay-attack defense mechanism for applications like the discord bot that don't have access to the user's keys would be really nice.

Contributor guide

Research direction
Investigate the current sendMoney response in the bot's code and determine where to add instructional text for the user (e.g., 'check your DM' message and link instructions). Consider also a replay attack defense mechanism if time permits, but focus on the text changes.
Tech stack
typescript
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90