aws/aws-encryption-sdk-cli

Wrong formatting in the deprecated python warning

Open

#357 opened on Jan 20, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (42 forks)auto 404
good first issuemaintenance

Repository metrics

Stars
 (81 stars)
PR merge metrics
 (PR metrics pending)

Description

Problem:

https://github.com/aws/aws-encryption-sdk-cli/blob/5fc460ec800e7f712e9574be672ef04bdafcc307/src/aws_encryption_sdk_cli/compatability.py#L38

The minimum_version and date seem to have been swapped in the deprecated python warning.

Solution:

Putting the params["date"] before the minimum_version[0] should fix the issue.

Contributor guide

Research direction
Swap the order of `params['date']` and `minimum version[0]` in the deprecated warning message at the referenced line.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90