aviaviavi/curl-runnings

Add ability to supply cert file

Open

#70 opened on Apr 16, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Haskell (13 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (160 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Documenting an issue uncovered by @flokli in a private repo that I'll describe here:

curl-runnings uses http-client-tls, which apparently has no nice way to configure your own cert file.

@flokli opened snoyberg/http-client#461, so http-client-tls honors SSL_CERT_FILE.

He recommended Switching Network.HTTP.Client.TLS to Network.HTTP.Client.OpenSSL and adjusting noVerifyTlsSettings should be sufficient

Contributor guide

Research direction
Switch from http client tls to http client openssl and adjust noVerifyTlsSettings to support custom cert files.
Tech stack
haskell
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
HaskellOpenSSL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50