automerge/automerge-swift

extend ChangeHash internal initializer to use Automerge core logic

Open

#193 opened on Jul 13, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Swift (25 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (320 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

From #191 :

In the automerge crate we have a TryFrom<&[u8]> implementation for ChangeHash. This is the supported way of converting bytes into a ChangeHash and is where we would handle future inconsistencies in hash format (not that I expect any at this point). If possible I think it would be best to expose this method up through the Uniffi UDL rather than assuming that any 32 byte array is a valid change hash. (This also applies to the serialization step, except we're already using ChangeHash::as_bytes when we generate the bytes which we pass to the Swift side).

Contributor guide

Research direction
Investigate the automerge crate's TryFrom<&[u8]> implementation for ChangeHash and update the Swift binding's internal initializer to use that via Uniffi instead of assuming any 32 byte array is valid.
Tech stack
swiftrust
Domain
mobilebackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftRustUniffi
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75