atuinsh/atuin

Installer script detects Fedora as Ubuntu when running in WSL

Closed

#1,083 opened on Jul 3, 2023

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Rust (840 forks)batch import
help wanted

Repository metrics

Stars
 (29,714 stars)
PR merge metrics
 (Avg merge 9d 2h) (16 merged PRs in 30d)

Description

I’m the atypical user who runs Fedora in WSL, not the de-facto standard Ubuntu. However, if the install sript sees microsoft in the kernel version it assumes that Ubuntu is installed.

Contributor guide

Research direction
Inspect the installer script to see how it detects the OS, specifically the logic that uses 'microsoft' in kernel version to assume Ubuntu. Modify it to detect the actual distribution (e.g., using /etc/os release or lsb release) for WSL environments.
Tech stack
rustshell
Domain
devopstooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
WSLFedora
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70