atom/github

Replace getDerivedStateFromProps with memoization

Open

#1,611 opened on Jul 26, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (469 forks)batch import
code-cleanup :wrench:good first issue

Repository metrics

Stars
 (1,069 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Where possible, it would be cleaner and less error-prone to replace components that implement static getDerivedStateFromProps() with PureComponents or memoize-one:

Contributor guide

Research direction
Find all React components that use static getDerivedStateFromProps. For each component, determine if it can be converted to a PureComponent or if memoization with memoize one is appropriate. Follow the guidance in the linked blog post to replace the lifecycle method. Run the existing tests to ensure no regression.
Tech stack
reactjavascript
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75