assisrafael/angular-input-masks

[cep] Validation is not working

Open

#173 opened on Apr 4, 2016

View on GitHubContributor guide
 (6 comments) (1 reaction) (0 assignees)JavaScript (330 forks)batch import
help wantedneeds: work

Repository metrics

Stars
 (956 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When trying to use cep as a number, validation does not work, because the validation is checking for value.length. We could add a toString() before checking length.

Contributor guide

Research direction
Add a call to toString() on the value before checking its length in the CEP validation logic.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85