aspiers/ly2video

midi file extension not honored / misleading error message

Open

#99 opened on May 12, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (28 forks)github user discovery
bugeasyhelp wanted

Repository metrics

Stars
 (189 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I tried out ly2video with a lilypond file where I set the midi file extension to the standard .mid
#(ly:set-option 'midi-extension "mid")

ly2video is looking for .midi hardcoded so cli.py:1565 gave me the error "Failed to generate MIDI file".

Maybe ly2video could parse for that Scheme command, or at least rewrite the error message to inform the user of exactly which file it is looking for, and not assume that the midi file was not generated. For example instead of showing sanitisedLyFileName, show midiPath so one can check themselves.

Contributor guide

Research direction
Investigate how ly2video currently generates MIDI files, then modify cli.py to parse the Scheme command #(ly:set option 'midi extension ...) or improve the error message to show the expected file path.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonLilyPond
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50