asmaloney/libE57Format

MinGW fails to compile due to warnings

Open

#247 opened on Apr 21, 2023

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C++ (82 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (187 stars)
PR merge metrics
 (PR metrics pending)

Description

(From here: https://github.com/asmaloney/libE57Format/issues/245#issuecomment-1518088249)

I think his fix in CRCpp (which is what I used here) won't work for MinGW.

@UshnaGul - can you try changing the checks in CheckedFile.cpp from

#if defined( WIN32 ) || defined( _WIN32 ) || defined( WINCE )

to

#if defined( _MSC_VER )

That should turn off the pragmas MinGW doesn't understand. Not sure if it will throw other errors though.

Contributor guide

Research direction
Modify the #if defined preprocessor checks in CheckedFile.cpp to use MSC VER instead of WIN32 to avoid MinGW pragma warnings.
Tech stack
ccpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++MinGW
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70