apache/pinot

Flaky Test: PartialUpsertTableRebalanceIntegrationTest

Closed

#12,412 opened on Feb 13, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Java (1,234 forks)batch import
flaky-testhelp wanted

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (Avg merge 6d 7h) (186 merged PRs in 30d)

Description

Seeing this occasionally. Maybe 60s is not enough for the rebalance to converge.

Error:  Tests run: 5, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 86.82 s <<< FAILURE! -- in org.apache.pinot.integration.tests.PartialUpsertTableRebalanceIntegrationTest
Error:  org.apache.pinot.integration.tests.PartialUpsertTableRebalanceIntegrationTest.testRebalance -- Time elapsed: 10.94 s
Error:  org.apache.pinot.integration.tests.PartialUpsertTableRebalanceIntegrationTest.afterMethod -- Time elapsed: 70.99 s <<< FAILURE!
java.lang.AssertionError: Failed to meet condition in 60000ms, error message: Failed to drop the segments
	at org.testng.Assert.fail(Assert.java:111)
	at org.apache.pinot.util.TestUtils.waitForCondition(TestUtils.java:111)
	at org.apache.pinot.util.TestUtils.waitForCondition(TestUtils.java:88)
	at org.apache.pinot.util.TestUtils.waitForCondition(TestUtils.java:93)
	at org.apache.pinot.integration.tests.PartialUpsertTableRebalanceIntegrationTest.afterMethod(PartialUpsertTableRebalanceIntegrationTest.java:192)

Contributor guide

Research direction
Investigate the test failure in PartialUpsertTableRebalanceIntegrationTest and adjust the timeout or the rebalance condition to make the test more reliable.
Tech stack
java
Domain
databasebackend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaTesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60