apache/gravitino

[Improvement] createTable may return success even when Gravitino metadata persistence fails

Open

#10,630 opened on Apr 1, 2026

View on GitHubContributor guide
 (3 comments) (0 reactions) (1 assignee)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be improved?

In TableOperationDispatcher.createTable(...), Gravitino first creates the table in the underlying catalog, then writes the TableEntity to the entity store.

If store.put(tableEntity, true) fails, the exception is logged but swallowed, and the method still returns success.

This can leave the external table created, even though Gravitino metadata was not persisted. Clients will receive a successful create-table response even though Gravitino is in an inconsistent state.

Location is TableOperationDispatcher.java (line 640)

How should we improve?

Do not swallow the store.put(...) failure. Propagate the exception so create-table fails instead of returning false success OR if best-effort behavior is intended, return an explicit partial-success/inconsistent-state result and add a test for this path.

Add/modify an existing unit test to check for this.

Contributor guide

Research direction
Inspect the createTable method in TableOperationDispatcher.java around line 640. Understand how store.put failure is caught and logged, then modify to propagate the exception. Write a unit test that simulates store failure and verifies the method throws an exception instead of returning success.
Tech stack
java
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGitGravitino basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75