apache/beam

JsonToRow can catch errors in downstream transforms

Closed

#20,935 opened on Jun 4, 2022

View on GitHubContributor guide
 (2 comments) (0 reactions) (1 assignee)Java (4,097 forks)batch import
P3bugcoregood first issuejava

Repository metrics

Stars
 (7,313 stars)
PR merge metrics
 (Avg merge 6d) (243 merged PRs in 30d)

Description

JsonToRow :

  |try {| | | | | |output.get(PARSED_LINE).output(jsonToRow(objectMapper(), element));| | | | | |} catch (Exception ex) {|

Can catch errors thrown downstream with runners that have fusion. This can be confusing as it can appear that the issue happens in the parse operation , when its really happening in a transform further down the DAG. This is made worse as different runners can show different behaviour in this situation.

 

Replace with try{i = parse}catch{}  if i not null output

Imported from Jira BEAM-11940. Original Jira may contain additional context. Reported by: rarokni@gmail.com.

Contributor guide

Research direction
Identify the location of the try catch block in JsonToRow transform and refactor it to only catch parse exceptions, not downstream errors. Ensure that the transform properly handles null and error cases without swallowing exceptions from subsequent transforms.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaApache Beam
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65