apache/apisix

feat: remove openldap dependencies from apisix

Open

#7,865 opened on Sep 6, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Lua (2,860 forks)batch import
good first issuepending

Repository metrics

Stars
 (16,597 stars)
PR merge metrics
 (Avg merge 7d 18h) (97 merged PRs in 30d)

Description

Description

With lua-resty-ldap, apisix does not need openldap related dependencies anymore.

We could remove it in these files:

  • .github/workflows/fuzzing-ci.yaml:53: sudo apt-get install -y git openresty curl openresty-openssl111-dev unzip make gcc libldap2-dev
  • ci/centos7-ci.sh:26: git sudo openldap-devel which libxml2-devel openssl-devel libxslt-devel
  • ci/common.sh:130: apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
  • ci/performance_test.sh:25: apt-get -y install lua5.1 liblua5.1-0-dev libldap2-dev
  • ci/pod/docker-compose.plugin.yml:148: openldap:
  • docs/en/latest/building-apisix.md:94: brew install openldap
  • t/chaos/utils/Dockerfile:34: openldap-dev
  • utils/install-dependencies.sh:49: local common_dep="curl wget git gcc openresty-openssl111-devel unzip pcre pcre-devel openldap-devel"
  • utils/install-dependencies.sh:87: sudo apt-get install -y git openresty curl openresty-openssl111-dev make gcc libpcre3 libpcre3-dev libldap2-dev unzip
  • utils/install-dependencies.sh:93: brew install openresty/brew/openresty luarocks lua@5.1 wget curl git pcre openldap
  • utils/linux-install-openresty.sh:51:sudo apt-get install "$openresty" openresty-openssl111-debug-dev libldap2-dev

We should also remove it in build-tools: https://github.com/api7/apisix-build-tools/blob/acedbc07990929efd066b1c25b53e09c6d0d085f/package-apisix.sh#L10

Contributor guide

Research direction
Review each file listed in the issue (e.g., .github/workflows/fuzzing ci.yaml, ci/common.sh, etc.) and remove the openldap related packages from the apt get install lines and other references. Ensure the documentation in docs/en/latest/building apisix.md is updated. Test that the CI builds still pass after removal.
Tech stack
shelldockergithub actions
Domain
devopsci cddocumentation
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
shell scriptingfamiliarity with CI files
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80