ant-design/html2sketch

🐛[BUG]a标签在sketch插件中提供的web中调用getBoundingClientRect方法返回值问题

Open

#47 opened on Oct 28, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (27 forks)github user discovery
help wanted

Repository metrics

Stars
 (180 stars)
PR merge metrics
 (PR metrics pending)

Description

🐛 bug 描述

a标签在sketch插件中提供的web中执行
const bcr = node.getBoundingClientRect(); 这段代码的时候，不能返回准确的自身rect值，返回的是父节点的值，有什么能替换的方法么

modify

上面描述的不准确，返回的还是自身的值 但是因为换行返回的rect被撑开了 在设置textLayer的x和y的时候就会出现不准确的情况 test

如图得到的rect就是红色的框

📷 复现步骤

在转换如下节点时复现的问题

<span>
阅读
<a >xxxx协议</a>
</span>

Contributor guide

Research direction
Investigate the getBoundingClientRect behavior for inline elements like <a> inside a <span> in the Sketch web view. The issue may be due to line wrapping causing the bounding box to include the entire line. Consider using range.getClientRects() or getClientRects() to get individual line rects, or check if there is a layout issue specific to Sketch's web view. Also verify if the text layer positioning is affected.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptHTMLCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40