ant-design/ant-design

Modal 下 destroyOnClose 属性 失效

Closed

#28,847 opened on Jan 13, 2021

View on GitHubContributor guide
 (5 comments) (2 reactions) (0 assignees)TypeScript (54,612 forks)batch import
Inactivehelp wanted🐛 Bug

Repository metrics

Stars
 (98,031 stars)
PR merge metrics
 (Avg merge 3d 4h) (248 merged PRs in 30d)

Description

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://fvrw0.csb.app/

Steps to reproduce

modal下使用video标签，播放后，关闭modal video or audio标签依然播放， 且重新打开modal 依然存在

What is expected?

modal关闭后销毁媒体标签

What is actually happening?

modal关闭后未销毁标签

Environment Info
antd 4.10.2
React 16.12.0
System win10
Browser firefox

Contributor guide

Research direction
Investigate the destroyOnClose implementation in Modal, focusing on how child components are unmounted. Check if the issue is related to React's state management or ref usage, and consider if the media element's playback persists due to improper cleanup in componentWillUnmount or useEffect cleanup.
Tech stack
javascripttypescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Reactantd
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60