ant-design/ant-design-mobile

src/components/swiper/swiper.tsx 第362行 width: `${startIndex * 100}%`, 在垂直的情况下应该改为 height: `${startIndex * 100}%`

Closed

#6,567 opened on Mar 7, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,313 forks)batch import
bughelp wanted

Repository metrics

Stars
 (11,238 stars)
PR merge metrics
 (Avg merge 7h 11m) (8 merged PRs in 30d)

Description

Version of antd-mobile

v5.34.0

Operating system and its version

No response

Browser and its version

No response

Sandbox to reproduce

No response

What happened?

src/components/swiper/swiper.tsx 第362行 width: ${startIndex * 100}%, 在direction='vertical'的情况下应该改为 height: ${startIndex * 100}%

Relevant log output

No response

Contributor guide

Research direction
Examine line 362 in src/components/swiper/swiper.tsx and check if the width property should be conditionally set to height when direction is 'vertical'. Implement the conditional logic.
Tech stack
typescriptreact
Domain
frontendmobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90