angular/components

Cdk Overlay backdrop does not respect noopanimations

Closed

#18,645 opened on Feb 28, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)TypeScript (6,650 forks)batch import
GP4area: cdk/overlayhelp wanted

Repository metrics

Stars
 (24,044 stars)
PR merge metrics
 (Avg merge 3d 12h) (98 merged PRs in 30d)

Description

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/fork/components-issue

Steps to reproduce:

  1. import NoopAnimationsModule
  2. Create a dialog https://stackblitz.com/edit/angular-fdgmah (based on example dialog stackblitz)

Expected Behavior

What behavior were you expecting to see?

The dark overlay appears immediately with no animation

Actual Behavior

What behavior did you actually see?

The overlay backdrop fades in over 400ms.

Environment

  • Angular: 9.1
  • CDK/Material: 9.1
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Linux

Contributor guide

Research direction
Investigate the CDK Overlay backdrop animation code in the Angular components repository, likely in packages/cdk/overlay/backdrop.ts or similar. Check if NoopAnimationsModule is properly propagated to the backdrop animation. Review the existing comment for any additional details. The fix may involve setting the animation state directly when noop animations are enabled.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Angular basicsCDK Overlay knowledgeAngular animations
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30