angular-ui/ui-grid

isStartEditKey twice with different keycodes

Closed

#5,035 opened on Jan 27, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wantedneeds: analysis

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When i decorate the isStartEditKey function of uiGridEditService the function is called twice with two different keycodes. Maybe when i hit "t" i receive two keycodes, 84 first an then 116.

http://plnkr.co/edit/a14yxA?p=preview

Contributor guide

Research direction
Inspect the isStartEditKey function in uiGridEditService and trace the keydown event handler to understand why it fires twice with different keycodes.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65