angular-ui/ui-grid

Behavior 'Expand All' with angular animate 1.3.15 and ui-grid 3.0.0-RC21

Closed

#3,696 opened on Jun 5, 2015

View on GitHub
 (11 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
angular-animategood first issuetype: bug

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi,

I'm not sure why, and how, but the expand all action work fine, but the icons are not good. http://plnkr.co/edit/URYETKsjgPUOgFKPhfYK?p=preview

If I disable ngAnimate, it's working fine. Is this related to #3647 ?

Contributor guide

Research direction
Investigate the interaction between ngAnimate and ui grid's expand all behavior. Check if CSS transitions from ngAnimate are interfering with the toggling of icon classes. Compare with issue #3647 for related root cause. Use the provided Plunkr to reproduce and inspect DOM elements.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptAngularJSGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65