andersao/l5-repository

Filter doesn't work with presenter

Open

#449 opened on Oct 8, 2017

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)PHP (882 forks)batch import
help wanted

Repository metrics

Stars
 (4,198 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

when i use presenter in repository class getting this result :

{{Url}}/bazaars?token={{token}}&filter=id;name

{
    "data": [
        {
            "id": 1,
            "name": "temp",
            "address": null,
            "city": null,
            "province_id": null
        },
        {
            "id": 2,
            "name": "temp1",
            "address": null,
            "city": null,
            "province_id": null
        }
]

but i need this:

{
    "data": [
        {
            "id": 1,
            "name": "temp",
        },
        {
            "id": 2,
            "name": "temp1"
        }
]

and i'm using fractal transformer.

Contributor guide

Research direction
Investigate how the filter method interacts with the presenter/transformer in l5 repository. Check if the filter parameters are being applied correctly before the presenter transforms the data.
Tech stack
phplaravel
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PHPLaravel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60