amatt13/BossFight

Rework how much gold is awarded for overkill damage

Open

#45 opened on Apr 18, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (1 fork)auto 404
Back Endgood first issue

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

CalculateEarnedGoldForInvolvedPlayers() does not take into effect how much of the damage was overkill damage. This could be "calculated" by updating the SubtractHealth() function.

Remember to check that DoT effect is also correctly handled.

Should overkill damage be ignored? Should it only award a little bit extra gold?

Contributor guide

Research direction
Investigate the SubtractHealth() function and how overkill damage is calculated. Consider DoT effects and propose a formula for gold based on overkill damage percentage.
Tech stack
csharp
Domain
game dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70