amatt13/BossFight

"Sell()" is a method on PlayerWeapon.

Open

#14 opened on Jan 22, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (1 fork)auto 404
Back Endgood first issue

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

This should be moved to the ShopController or mayby a new buy/sell class. The function should be made general such that any item can be sold trough it.

We should also make sure that the player dosen't receive gold if the method fails. Likewise the player<->item relation should not be delted if the method fails.

Contributor guide

Research direction
Identify the current Sell() method in PlayerWeapon, design a general sell interface, move to ShopController, ensure transactional integrity.
Tech stack
csharp
Domain
game dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70