alvarcarto/url-to-pdf-api

scrollPage bug

Open

#52 opened on Jan 2, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (778 forks)batch import
PR welcomehelp wanted

Repository metrics

Stars
 (7,103 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There are some websites such as example using a special lazy loading strategy.

When users scroll quickly(<300ms) they do not load image. Just when users stop to look at the content they load image.

So, I think that we need another option (scrollInterval) to let user to test and decide the interval.

releated discussions:

https://github.com/GoogleChrome/puppeteer/issues/338#issuecomment-333301117

Thanks!

Contributor guide

Research direction
Investigate lazy loading behavior on target websites and implement a configurable scroll interval option to handle rapid scrolling.
Tech stack
javascriptnodejs
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Puppeteerasync/await
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60