alibaba/xquic

[Bug]: stream_read_notify may not be call

Open

#205 opened on Jul 8, 2022

View on GitHubContributor guide
 (0 comments) (1 reaction) (1 assignee)C (389 forks)github user discovery
:star_struck: someone working on ithelp wanted

Repository metrics

Stars
 (1,892 stars)
PR merge metrics
 (PR metrics pending)

Description

What happened?

xqc_stream_recv always calls xqc_stream_shutdown_read, so when a stream has received fin and then xqc_stream_recv does not consume all the data, the left data will never be notified to application.

Steps To Reproduce

Only call xqc_stream_recv once in stream_read_notify with a small buffer.

Relevant log output

No response

Contributor guide

Research direction
Examine the logic in xqc stream recv and xqc stream shutdown read to ensure that when a stream has received FIN and data remains unread, the stream read notify callback is correctly invoked for the remaining data.
Tech stack
c
Domain
networking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CUnderstanding of QUIC protocol
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65