alibaba/sentinel-golang

[BUG] App name in metric is unknown_ go_ service

Open

#453 opened on Jan 12, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (453 forks)github user discovery
good first issue

Repository metrics

Stars
 (2,957 stars)
PR merge metrics
 (PR metrics pending)

Description

Issue Description

Type: bug report

Describe what happened

https://github.com/alibaba/sentinel-golang/blob/683c229b23a96c4ad07dc795da3730db8fd9d93c/exporter/metric/exporter.go#L35-L45

Since the above code (code 1) uses the init function and is executed before the following code (code 2), the app variable in code 1 is an error.

https://github.com/alibaba/sentinel-golang/blob/683c229b23a96c4ad07dc795da3730db8fd9d93c/api/init.go#L54-L74

Contributor guide

Research direction
Inspect the init execution order in Go and ensure the app variable is initialized before the exporter init function runs. Move the app initialization earlier or use lazy initialization.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70