alibaba/sentinel-golang

[BUG] getProcessCpuStat return value (in percentage) breaks compatibility

Open

#435 opened on Nov 10, 2021

View on GitHubContributor guide
 (0 comments) (1 reaction) (0 assignees)Go (453 forks)github user discovery
area/metricsgood first issuekind/bug

Repository metrics

Stars
 (2,957 stars)
PR merge metrics
 (PR metrics pending)

Description

Issue Description

Type: bug report

Describe what happened

getProcessCpuStat return value (in percentage) breaks compatibility. In previous implementation, the CPU usage representation is the value between [0.0, 1.0]. Since 1.0.x, the CPU usage from getProcessCpuStat was changed to percentage value (i.e. 0-100), which breaks compatibility and affects system adaptive rules.

Describe what you expected to happen

getProcessCpuStat keeps compatibility and unifys the CPU usage value to [0.0, 1.0]

Tell us your environment

Sentinel Go v1.0.3

Contributor guide

Research direction
Compare the implementation of getProcessCpuStat between versions to identify the change that turned the return value from a fraction to a percentage. Restore the fraction format or add a configurable option.
Tech stack
go
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65