alibaba/sentinel-golang

Hotspot: enhance the LRU cache victim mechanism in hotspot module

Open

#254 opened on Sep 27, 2020

View on GitHubContributor guide
 (3 comments) (2 reactions) (0 assignees)Go (453 forks)github user discovery
area/flow-controlgood first issuekind/discussionkind/enhancement

Repository metrics

Stars
 (2,957 stars)
PR merge metrics
 (PR metrics pending)

Description

Issue Description

Currently, hotspot module use LRU cache to store and victim the frequency parameters. The LRU victim mechanism is okay but in some extreme scenario might work not well, such as: iteration, cold data can push out hot data

We might optimize the cache mechanism, such as java cache framework: caffeine: Type: feature request

Describe what feature you want

Additional context

Add any other context or screenshots about the feature request here.

Contributor guide

Research direction
Study the current LRU implementation in the hotspot module and explore integrating an adaptive cache policy like W TinyLFU as used in Caffeine.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoCaching concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50