alibaba/pipcook

cli: add time prefix for default logger

Open

#900 opened on Oct 9, 2021

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)TypeScript (211 forks)github user discovery
good first issue

Repository metrics

Stars
 (2,595 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We distinguish different types of terminals by judging process.stdout. On the default terminal, we use console to output logs, while on the TTY terminal, we use the ora. We have added a time prefix to Ttylogger, but this feature has not been implemented on the DefaultLogger. Here is the DefaultLogger: https://github.com/alibaba/pipcook/blob/main/packages/cli/src/utils/index.ts#L212

Contributor guide

Research direction
Study the Ttylogger implementation for time prefix, then replicate the logic in DefaultLogger.
Tech stack
typescriptnodejs
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75