alibaba/Sentinel

Flaky test

Open

#2,974 opened on Nov 26, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (8,150 forks)batch import
area/testgood first issue

Repository metrics

Stars
 (23,109 stars)
PR merge metrics
 (Avg merge 6d) (1 merged PR in 30d)

Description

Issue Description

Bug report

Describe what happened (or what feature you want)

The test com.alibaba.csp.sentinel.adapter.reactor.MonoSentinelOperatorIntegrationTest.testEmitSingleLongTimeRt fails when run by itself. But it passes when other methods run before it. Thus, the test is flaky Acc. to the definitions mentioned in IDOFT.

Describe what you expected to happen

The test should pass when run on its own.

How to reproduce it (as minimally and precisely as possible)

Run the test on its own. It will fail. Run the test class. It will pass.

Tell us your environment

Java 1.8 Windows 10 Education. Maven 3.6.3

Anything else we need to know?

Contributor guide

Research direction
Reproduce the flaky test by running it in isolation. Check for shared static state or test order dependencies in the test class. Use maven surefire plugin to run single test methods and compare behavior. Look into the reactor adapter code for mutable state that might be left over from previous tests.
Tech stack
java
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMavenJUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40