alibaba/Sentinel

sentinel springwebmvc不支持异步async请求

Open

#2,447 opened on Nov 12, 2021

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Java (8,150 forks)batch import
area/integrationsgood first issuekind/bug

Repository metrics

Stars
 (23,109 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

我们在Controller使用了WebAsyncTask的异步返回方式，这种情况下，AbstractSentinelInterceptor中的prehandle会执行两次，rckey变成了2，但是afterCompletion只会执行一次（而且还是在另外一个线程请求的），导致clean的逻辑无法执行，这样entry和context在threadlocal中一直无法清除，最终oom

Contributor guide

Research direction
Investigate the lifecycle of AbstractSentinelInterceptor when handling async requests, specifically the mismatch between preHandle and afterCompletion calls for WebAsyncTask. Propose a fix to ensure proper cleanup of ThreadLocal variables.
Tech stack
javaspring
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaSpring MVCSentinel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30