airbnb/rheostat

Aria-labels can't be added to slider buttons

Open

#273 opened on Jan 3, 2020

View on GitHub
 (3 comments) (9 reactions) (0 assignees)JavaScript (185 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,689 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

For compliance, I need to add aria-labels to the slider buttons in an implementation like this one: http://localhost:9001/?path=/story/slider--rtl-multiple-handle. There doesn't seem to be a way to do this currently.

Contributor guide

Research direction
Look at the Slider component source to identify where the handle buttons are rendered, then add a prop to accept aria label and pass it to those buttons.
Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70