Xabaril/AspNetCore.Diagnostics.HealthChecks

Why do you pass HttpClientFactory as function?

Open

#474 opened on Apr 6, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (737 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (3,776 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, Can someone please can explain to me why pass the HttpClientFactory as a function and not just as for instance?

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/d808dc0acdcd3f17c1156104f5eef369ccc293ac/src/HealthChecks.Consul/DependencyInjection/ConsulHealthCheckBuilderExtensions.cs#L44

Contributor guide

Research direction
Examine the file ConsulHealthCheckBuilderExtensions.cs line 44 to understand the factory pattern used for HttpClientFactory. The existing comment in the issue likely explains the design rationale. Consider whether the pattern is used for delayed resolution of dependencies or to support different registration scenarios. There are no open PRs; the issue may be resolved but not closed.
Tech stack
csharp
Domain
backendapi
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#ASP.NET CoreHttpClient
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20