TigerVNC/tigervnc

IPv6 address in HostsFile not working

Open

#1,389 opened on Dec 8, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (1,176 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (7,396 stars)
PR merge metrics
 (Avg merge 95d 10h) (4 merged PRs in 30d)

Description

Describe the bug When IPv6 address is in HostsFile Server quits after first attempted connection with log line: Main: unable to resolve host by name: Name or service not known

To Reproduce Steps to reproduce the behavior: Create HostsFile containing two lines: +IPv6 address - run x0vncserver with -HostsFile option

Try to connect.

Expected behavior Server parses IPv6 address and does not quit.

Server (please complete the following information):

  • OS: Linux Mint
  • VNC server: TigerVNC Server
  • VNC server version: 1.10.1
  • Server downloaded from: Ubuntu apt repository
  • Server was started using: x0vncserver

Additional context I think this might be caused by too short readline here 32 chars is to little for IPv6 address (although i don't know if this is the only problem with parsing). Log line might be coming from here or here

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Research direction
Inspect the readline buffer size in x0vncserver.cxx (line 165) and modify it to accommodate IPv6 addresses. Also verify the hostname resolution logic in TcpSocket.cxx around lines 136 and 637.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75