TigerVNC/tigervnc

Meaningful exit codes from vncviewer

Open

#1,008 opened on May 1, 2020

View on GitHub
 (9 comments) (1 reaction) (0 assignees)C++ (1,176 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (7,396 stars)
PR merge metrics
 (Avg merge 95d 10h) (4 merged PRs in 30d)

Description

If there is no VNC server running on localhost and I still try to connect, I get the following output:

$ xtigervncviewer -AlertOnFatalError=0 localhost

TigerVNC Viewer 64-bit v1.9.0
Built on: 2020-01-23 18:03
Copyright (C) 1999-2018 TigerVNC Team and many others (see README.rst)
See http://www.tigervnc.org for information on TigerVNC.

Fri May  1 15:55:44 2020
 DecodeManager: Detected 4 CPU core(s)
 DecodeManager: Creating 4 decoder thread(s)
 CConn:       unable to create socket: Address family not supported by protocol
              (97)
$ echo $?
0

I would have expected a non-zero exit code.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Research direction
Investigate the connection failure path in vncviewer and ensure a non zero exit code is returned on errors.
Tech stack
cpp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70