Squarelet/squarelet

add edit button in squares

Open

#12 opened on Nov 19, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Vue (2 forks)auto 404
UIgood first issuehelp wanted

Repository metrics

Stars
 (26 stars)
PR merge metrics
 (PR metrics pending)

Description

When I include an iframe embed to a square, it is only possible to edit this iframe when I click outside of its area. An "Edit"-Button (top right?) would make it much easier to edit existing content.

try with this iframe: <iframe src="https://h5p.org/h5p/embed/362759" width="800" height="800" frameborder="0" allowfullscreen="allowfullscreen"></iframe><script src="https://h5p.org/sites/all/modules/h5p/library/js/h5p-resizer.js" charset="UTF-8"></script>

Editing would start when either double-clicking an existing square or clicking once on it (=buttons appear) and then clicking the edit button.

Example: bildschirmfoto 2018-11-20 um 12 20 01

Contributor guide

Research direction
Examine the Square component to understand how iframes are rendered. Add an edit button that appears on hover or click, triggering the edit mode for the square's content.
Tech stack
vue
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Vue
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65