SimulatedGREG/electron-vue

console.log from main process doesn't print CJK characters

Open

#605 opened on May 4, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,506 forks)batch import
bughelp wanted

Repository metrics

Stars
 (15,386 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

"console.log" Chinese, Japanese in main process, cannot print.

Describe the issue / bug.

#

in "https://github.com/SimulatedGREG/electron-vue/tree/master/template/.electron-vue/dev-runner.js" line: 137


137: if (/[0-9A-z]+/.test(log)) {
   ....
}

log print english or number only.

Change


if (/[0-9A-z]+/.test(log)) {
   ....
}

to


if (log) {
   ....
}

or remove can fix it.

Contributor guide

Research direction
Locate the dev runner.js file at the specified path, find line 137, and replace the regex test `/^[0-9A z]+$/.test(log)` with a simple truthy check like `if (log)`. This will allow console.log to print CJK characters.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90