SigNoz/signoz

Feat(FE): Global Time Visibility as per route

Open

#1,659 opened on Oct 25, 2022

View on GitHub
 (6 comments) (0 reactions) (1 assignee)TypeScript (976 forks)batch import
good first issuehacktoberfest

Repository metrics

Stars
 (16,037 stars)
PR merge metrics
 (Avg merge 5d 13h) (222 merged PRs in 30d)

Description

Is your feature request related to a problem?

Please describe. Right now to show the global header we are using routesToSkip , need to refactor the logic to display according to the route where this component is required

eg:

routes = ['/services','/service/:id','/trace','/logs','/dashboard/:dashboardId','/exceptions','/service-map']

Describe the solution you'd like

we can keep an array of routes in which the header needs to disable

Thank you for your feature request – we love each and every one!

Contributor guide

Research direction
Examine the current implementation in `frontend/src/container/TopNav/index.tsx` that uses `routesToSkip`. Identify the routes where the global header should be shown instead of hidden. Refactor by switching to a whitelist approach, and test the changes with the mentioned routes like `/services`, `/trace`, etc.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScriptBasic routing concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45