SemanticMediaWiki/SemanticResultFormats

[mode] Mode format returns mode count, not the actual mode

Open

#979 opened on Nov 15, 2025

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (87 forks)auto 404
good first issue

Repository metrics

Stars
 (52 stars)
PR merge metrics
 (PR metrics pending)

Description

It seems that the mode format returns how many times the mode appears, not the actual mode itself https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/42c26905f5d9f25a321a0c3b286d5b0d239a8083/formats/math/SRF_Math.php#L187 https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/42c26905f5d9f25a321a0c3b286d5b0d239a8083/formats/math/SRF_Math.php#L189 https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/42c26905f5d9f25a321a0c3b286d5b0d239a8083/formats/math/SRF_Math.php#L201 array_count_values gives counts as values, and max gets the max value, meaning $max is a count, not the most common property value

It seems the unit test even expects the count instead of the actual mode

https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/42c26905f5d9f25a321a0c3b286d5b0d239a8083/tests/phpunit/Integration/JSONScript/TestCases/math-01.json#L309-L313

https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/42c26905f5d9f25a321a0c3b286d5b0d239a8083/tests/phpunit/Integration/JSONScript/TestCases/math-01.json#L94-L95

https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/42c26905f5d9f25a321a0c3b286d5b0d239a8083/tests/phpunit/Integration/JSONScript/TestCases/math-01.json#L14-L15

The mode should be 333, the only number, but instead it expects and gets how many times 333 occurs

Contributor guide

Research direction
Inspect SRF Math.php lines 187-201 and the test file math 01.json to understand how array count values is used. Correct the logic to return the actual mode value instead of the count.
Tech stack
php
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70