Semantic-Org/Semantic-UI-React

Radio: onChange not triggered for radio toggle with id

Open

#3,737 opened on Aug 6, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (4,065 forks)batch import
bughelp wanted

Repository metrics

Stars
 (13,136 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Bug Report

onChange not triggered on Radio with toggle and id props. And does okay without id or with name props.

Steps

  1. Add id and toggle props to Radio component
  2. Click on radio element

Expected Result

onChange should be triggered.

Actual Result

onChange is not triggered.

Version

0.87.3

Testcase

https://codesandbox.io/embed/semantic-ui-react-example-yowvx

Contributor guide

Research direction
Investigate the Radio component's source code in Semantic UI React, focusing on the event handler when both 'id' and 'toggle' props are provided. Check the component's onChange implementation and see if there is a conflict with the 'id' attribute. Reproduce the bug using the provided CodeSandbox. Look at existing tests for Radio to understand expected behavior and consider adding a test for this specific case.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React basicsSemantic UI React usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80